netdev - Re: [PATCH] atm: correct sysfs 'device' link creation and parent relationships

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikhkVPcibAH8cSRvZSLop=Ew19Tn=KtY7prkKUn@mail.gmail.com>
Date:	Tue, 7 Dec 2010 08:35:53 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Dan Williams <dcbw@...hat.com>
Cc:	netdev@...r.kernel.org, Duncan Sands <duncan.sands@...e.fr>,
	linux-usb@...r.kernel.org, Chas Williams <chas@....nrl.navy.mil>
Subject: Re: [PATCH] atm: correct sysfs 'device' link creation and parent relationships

On Sun, Dec 5, 2010 at 23:17, Dan Williams <dcbw@...hat.com> wrote:
> The ATM subsystem was incorrectly creating the 'device' link for ATM
> nodes in sysfs.  This led to incorrect device/parent relationships
> exposed by sysfs and udev.  Instead of rolling the 'device' link by hand
> in the generic ATM code, pass each ATM driver's bus device down to the
> sysfs code and let sysfs do this stuff correctly.

Looks good to me.

It's wrong for any subsystem to ever create a file or link named
"device". It's a built-in driver-core managed property which appears
automatically as soon as the parent-device relations are correctly
established.

Udev/libudev intentionally refuses to follow any devices pointed to by
"broken" device links. So this patch is needed to make ATM devices
working properly with usual userspace tools.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html