netdev - Re: [PATCH] Insert interrupt URB after resume, so that status transfers can flow.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1291690674.2285.229.camel@helium>
Date:	Mon, 06 Dec 2010 18:57:54 -0800
From:	David Brownell <david-b@...bell.net>
To:	Indrek Peri <Indrek.Peri@...csson.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Insert interrupt URB after resume, so that status
 transfers can flow.

Building on my comment about your other patch ... shouldn't this be just
another part of the "resume driver" action,
like refilling the RX urb queue?

For the same reasons ... NAK.  It looks like the work to add suspend and
resume processing to this driver had a few holes, and resume handling
can be simplified by combining re-activation of RX processing and this
status reporting (where relevant) in one routine.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html