netdev - Re: [PATCH] atm: correct sysfs 'device' link creation and parent relationships

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291854831.16839.12.camel@dcbw.foobar.com>
Date:	Wed, 08 Dec 2010 18:33:49 -0600
From:	Dan Williams <dcbw@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	kay.sievers@...y.org, netdev@...r.kernel.org, duncan.sands@...e.fr,
	linux-usb@...r.kernel.org, chas@....nrl.navy.mil
Subject: Re: [PATCH] atm: correct sysfs 'device' link creation and parent
 relationships

On Wed, 2010-12-08 at 12:15 -0800, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 08 Dec 2010 10:11:21 -0800 (PST)
> 
> > From: Kay Sievers <kay.sievers@...y.org>
> > Date: Tue, 7 Dec 2010 08:35:53 +0100
> > 
> >> On Sun, Dec 5, 2010 at 23:17, Dan Williams <dcbw@...hat.com> wrote:
> >>> The ATM subsystem was incorrectly creating the 'device' link for ATM
> >>> nodes in sysfs.  This led to incorrect device/parent relationships
> >>> exposed by sysfs and udev.  Instead of rolling the 'device' link by hand
> >>> in the generic ATM code, pass each ATM driver's bus device down to the
> >>> sysfs code and let sysfs do this stuff correctly.
> >> 
> >> Looks good to me.
> > 
> > I've applied this to net-2.6, thanks Dan.
> 
> Actually I'm reverting, it breaks the build.
> 
> Did you even grep for "atm_dev_register()" after changning the number
> of arguments, or were you depending upon build failures to guide you?

What seems to have happened here was that I built against my installed
kernel config, which apparently does not enable a few of the drivers,
and thus I missed the error.  I apologize, I will submit a new patch,
and I will not let this happen again.

Dan

> Please never do the latter, as it always leads to things like this.
> 
> drivers/atm/fore200e.c:2577:7: error: too few arguments to function 'atm_dev_register'
> drivers/atm/iphase.c:3175:2: error: too few arguments to function 'atm_dev_register'



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html