netdev - Re: [v3 PATCH 1/2] bonding: sync netpoll code with bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D0087EE.90307@redhat.com>
Date:	Thu, 09 Dec 2010 15:40:30 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Neil Horman <nhorman@...hat.com>
CC:	linux-kernel@...r.kernel.org, Jiri Pirko <jpirko@...hat.com>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Herbert Xu <herbert@...dor.hengli.com.au>,
	bonding-devel@...ts.sourceforge.net,
	Jay Vosburgh <fubar@...ibm.com>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [v3 PATCH 1/2] bonding: sync netpoll code with bridge

On 12/09/10 15:33, Cong Wang wrote:
>>>
>>>       /* close slave before restoring its mac address */
>>>       dev_close(slave_dev);
>>> @@ -2061,6 +2098,7 @@ static int  bond_release_and_destroy(struct
>>> net_device *bond_dev,
>>>
>>>       ret = bond_release(bond_dev, slave_dev);
>>>       if ((ret == 0)&&  (bond->slave_cnt == 0)) {
>>> +        bond_dev->priv_flags |= IFF_DISABLE_NETPOLL;
>> Why are you setting IFF_DISABLE_NETPOLL here?  That seems unnecessecary
>>
>
> It gets removed in patch 2/2. :)

Oops! I misread IFF_DISABLE_NETPOLL as IFF_IN_NETPOLL...

I think there is a small window between bond_release() and unregister_netdevice(),
setting this could prevent netpoll is setup again on this bond?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html