netdev - Re: [PATCH net-2.6] net/ipv6/udp.c: fix typo in flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101209142851.GC2820@psychotron.brq.redhat.com>
Date:	Thu, 9 Dec 2010 15:28:52 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-2.6] net/ipv6/udp.c: fix typo in flush_stack()

Thu, Dec 09, 2010 at 02:48:08PM CET, eric.dumazet@...il.com wrote:
>Le jeudi 09 décembre 2010 à 14:40 +0100, Jiri Pirko a écrit :
>> skb1 should be passed as parameter to sk_rcvqueues_full() here.
>> 
>> Signed-off-by: Jiri Pirko <jpirko@...hat.com>
>> 
>> diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
>> index 91def93..d2b268e 100644
>> --- a/net/ipv6/udp.c
>> +++ b/net/ipv6/udp.c
>> @@ -602,7 +602,7 @@ static void flush_stack(struct sock **stack, unsigned int count,
>>  
>>  		sk = stack[i];
>>  		if (skb1) {
>> -			if (sk_rcvqueues_full(sk, skb)) {
>> +			if (sk_rcvqueues_full(sk, skb1)) {
>>  				kfree_skb(skb1);
>>  				goto drop;
>>  			}
>
>net-2.6 ? Its the same truesize anyway...

I know it is.

>
>So it's not a bug, but a cosmetic change.
>(I am ok with it, but for net-next-2.6)

Anything you like.

>
>/*
> * Take into account size of receive queue and backlog queue
> */
>static inline bool sk_rcvqueues_full(const struct sock *sk, const struct sk_buff *skb)
>{
>        unsigned int qsize = sk->sk_backlog.len + atomic_read(&sk->sk_rmem_alloc);
>
>        return qsize + skb->truesize > sk->sk_rcvbuf;
>}
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html