netdev - Re: [PATCH] iproute2: ip: add wilcard support for device matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Dec 2010 19:32:59 +0200
From:	Octavian Purdila <opurdila@...acom.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>, netdev@...r.kernel.org,
	"Lucian Adrian Grijincu" <lucian.grijincu@...il.com>,
	Vlad Dogaru <ddvlad@...edu.org>
Subject: Re: [PATCH] iproute2: ip: add wilcard support for device matching

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Friday 10 December 2010, 18:32:20

> Le vendredi 10 décembre 2010 à 08:18 -0800, Stephen Hemminger a écrit :
> > On Fri, 10 Dec 2010 16:58:12 +0200
> > 
> > Octavian Purdila <opurdila@...acom.com> wrote:
> > > Allow the users to specify a wildcard when selecting a device:
> > > 
> > > $ ip set link dev dummy* up
> > > 
> > > We do this by expanding the original command line in multiple lines
> > > which we then feed via a pipe to a forked ip processed run in batch
> > > mode.
> > 
> > Seems like feature creep. Can't you do this with bash completion
> > script instead.

This feature would make my life easier so to me its just a nice feature  :) 
Sure I can do it as a bash completion script but:

- bash does not run everywhere

- having it in iproute would make it available to everyone

- its userspace so the price to pay for a few more lines of code for usability 
seems reasonable

- I don't know how scalable you can make the bash completion script

> furthermore, "*" is allowed in a device name
> 
> ip link add link bond0 "vlan*" txqueuelen 100 type vlan id 999
> 

Would allowing escaping it fix the issue? Like:

ip link add link bond0 "vlan\*" txqueuelen 100 type vlan id 999

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html