netdev - Re: [PATCH v2] bridge: Fix return values of br_multicast_add_group/br_multicast_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101210225226.GL10190@distanz.ch>
Date:	Fri, 10 Dec 2010 23:52:27 +0100
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...ux-foundation.org, bridge@...ts.linux-foundation.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] bridge: Fix return values of
	br_multicast_add_group/br_multicast_new_group

On 2010-12-10 at 22:01:25 +0100, David Miller <davem@...emloft.net> wrote:
> From: Tobias Klauser <tklauser@...tanz.ch>
> Date: Fri, 10 Dec 2010 14:18:04 +0100
> 
> > If br_multicast_new_group returns NULL, we would return 0 (no error) to
> > the caller of br_multicast_add_group, which is not what we want. Instead
> > br_multicast_new_group should return ERR_PTR(-ENOMEM) in this case.
> > Also propagate the error number returned by br_mdb_rehash properly.
> > 
> > Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> 
> Looks good, applied to net-next-2.6
> 
> Please in the future make is clear, in your subject line, which
> tree this patch is meant for.
> 
> I had to figure it out by trial and error, because this patch
> does not apply properly to net-2.6

Sorry about that. I'll do so in the future.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html