netdev - Re: [PATCH net-next-2.6 1/2] ethtool: Report link-down while interface is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101210.155559.55870093.davem@davemloft.net>
Date:	Fri, 10 Dec 2010 15:55:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next-2.6 1/2] ethtool: Report link-down while
 interface is down

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 09 Dec 2010 22:08:35 +0000

> While an interface is down, many implementations of
> ethtool_ops::get_link, including the default, ethtool_op_get_link(),
> will report the last link state seen while the interface was up.  In
> general the current physical link state is not available if the
> interface is down.
> 
> Define ETHTOOL_GLINK to reflect whether the interface *and* any
> physical port have a working link, and consistently return 0 when the
> interface is down.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
> David,
> 
> I know you weren't keen on this, but if you don't accept it then please
> say what you think the proper semantics are.

No, I'm actually fine with this.

Applied, thanks Ben!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html