netdev - Re: [PATCH net-next-2.6] filter: use size of fetched data in __load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101209.204632.39180440.davem@davemloft.net>
Date:	Thu, 09 Dec 2010 20:46:32 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] filter: use size of fetched data in
 __load_pointer()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 08 Dec 2010 09:26:15 +0100

> __load_pointer() checks data we fetch from skb is included in head
> portion, but assumes we fetch one byte, instead of up to four.
> 
> This wont crash because we have extra bytes (struct skb_shared_info)
> after head, but this can read uninitialized bytes.
> 
> Fix this using size of the data (1, 2, 4 bytes) in the test.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

I'll apply this, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html