netdev - Re: [PATCH 0/7] e1000e: cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A78C6259B11833419567082E2DC0C25601D877D519@orsmsx508.amr.corp.intel.com>
Date:	Thu, 9 Dec 2010 21:20:00 -0800
From:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
To:	"asbjorn@...jorn.biz" <asbjorn@...jorn.biz>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/7] e1000e: cleanup

On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote:
> Hi,
> 
> This patchset fixes most checkstyle problems in e1000e.
> 
> Checkpatch summary:
> pre:	total:	221 errors,	129 warnings,	24520 lines checked
> post:	total:	2 errors,	34 warnings,	24533 lines checked
> 
> The two remaining errors are of the type "Macros with complex values
> should be enclosed in parenthesis", with macros containing 3 comma
> seperated values.
> 
> The remaining warnings are all caused by <20ms msleep usage, that should
> be replaced with usleep_range calls.
> 
> This patchset is based on top of jkirsher/net-next-2.6.git (67d5288)
> 
> Asbjoern Sloth Toennesen (7):
>   e1000e: cleanup: fix spacing issues
>   e1000e: cleanup: fix bracket issues
>   e1000e: cleanup: simplify E1000_ALL_* defines
>   e1000e: cleanup: fix long lines
>   e1000e: cleanup: fix space issues in ich8_* structs
>   e1000e: cleanup: swap arguments to avoid checkpatch errors
>   e1000e: cleanup: fix copyright notices to preferred style
> 
>  drivers/net/e1000e/82571.c   |   70 +++++++-------
>  drivers/net/e1000e/defines.h |  110 ++++++++++++-----------
>  drivers/net/e1000e/e1000.h   |   93 +++++++++++---------
>  drivers/net/e1000e/es2lan.c  |  135 ++++++++++++++--------------
>  drivers/net/e1000e/ethtool.c |   75 ++++++++--------
>  drivers/net/e1000e/hw.h      |   56 ++++++------
>  drivers/net/e1000e/ich8lan.c |  185 +++++++++++++++++++-------------------
>  drivers/net/e1000e/lib.c     |   78 ++++++++--------
>  drivers/net/e1000e/netdev.c  |  171 +++++++++++++++++------------------
>  drivers/net/e1000e/param.c   |   60 +++++++------
>  drivers/net/e1000e/phy.c     |  204 +++++++++++++++++++++---------------------
>  11 files changed, 625 insertions(+), 612 deletions(-)
> 
> -- 
> 1.7.2.3
> 

We already have patches queued up internally and are under validation
for the changes in patches 1 through 5 along along with other patches
for e1000e.  These patches will be posted shortly.

Patch 6 should be fixed in checkpatch.pl and from Florian's response, it
sounds like the fix is already out there.

Patch 7 does not resolve any warnings in checkpatch.pl and there is no
impending need to make this change.

So I won't be applying this series of patches.

Cheers,
Jeff

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)