netdev - Re: [PATCH] fix hostap registration order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.SOC.1.00.1012100918300.15996@math.ut.ee>
Date:	Fri, 10 Dec 2010 09:19:51 +0200 (EET)
From:	Meelis Roos <mroos@...ux.ee>
To:	j@...fi
cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH] fix hostap registration order

> > In 2.6.37-rc4, hostap_pci init gives a WARNING with backtrace telling 
> > that netif_stop_queue is called before register_netdev. Fix it by moving 
> > this call after register_netdev. Removes the warning and seems to work, 
> > but why is the call to netif_stop_queue needed at all after 
> > register_netdev?
> 
> It should simply not touch the queue state at all at this point.
> 
> Your change would add a race.  At the moment the device is registered
> it can be brought up, and then your code will eroneously modify
> the queue state.

OK, I can make a simpler patch for that but I would like to understand 
the original reasons for having netif_stop_queue there. Just a relict or 
still somehow important?

Jouni?

-- 
Meelis Roos (mroos@...ux.ee)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html