lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20101210.164721.85429801.davem@davemloft.net> Date: Fri, 10 Dec 2010 16:47:21 -0800 (PST) From: David Miller <davem@...emloft.net> To: nikai@...ai.net Cc: error27@...il.com, isdn@...ux-pingi.de, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] isdn: return -EFAULT if copy_from_user() fails From: Nicolas Kaiser <nikai@...ai.net> Date: Sat, 11 Dec 2010 01:41:54 +0100 > Ahem, we're printing this return value: > > * Dan Carpenter <error27@...il.com>: >> - if ((ret = copy_from_user(&size, p, sizeof(int)))) { > ^^^ >> + if (copy_from_user(&size, p, sizeof(int))) { >> printk(KERN_ERR"isar_load_firmware copy_from_user ret %d\n", ret); > ^^^ >> - return ret; >> + return -EFAULT; I'll fix this, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists