netdev - Re: [PATCH] pppoe.c: Fix kernel panic caused by __pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101211200823.GA1917@del.dom.local>
Date:	Sat, 11 Dec 2010 21:08:23 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Andrej Ota <andrej@....si>
Cc:	Paweł Staszewski <pstaszewski@...are.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	bugzilla-daemon@...zilla.kernel.org,
	bugme-daemon@...zilla.kernel.org, pstaszewski@...com.pl,
	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	Gorik Van Steenberge <gvs@...os.net>,
	Daniel Kenzelmann <kernel.bugzilla@...zelmann.dyndns.info>,
	Denys Fedoryshchenko <nuclearcat@...learcat.com>
Subject: Re: [PATCH] pppoe.c: Fix kernel panic caused by __pppoe_xmit

On Sat, Dec 11, 2010 at 01:44:38PM +0100, Andrej Ota wrote:
> __pppoe_xmit function return value was invalid resulting in
> additional call to kfree_skb on already freed skb. This resulted in
> memory corruption and consequent kernel panic after PPPoE peer
> terminated the link.
> 
> This fixes commit 55c95e738da85373965cb03b4f975d0fd559865b.
> 
> Signed-off-by: Jarek Poplawski [jarkao2@...il.com]
> Signed-off-by: Andrej Ota [andrej@....si]
> Reported-by: Pawel Staszewski [pstaszewski@...com.pl]

Thanks Andrej! I've only updated emails a bit.
Jarek P.

Reported-by: Gorik Van Steenberge <gvs@...os.net>
Reported-by: Daniel Kenzelmann <kernel.bugzilla@...zelmann.dyndns.info>
Reported-by: Denys Fedoryshchenko <nuclearcat@...learcat.com>
Reported-by: Pawel Staszewski <pstaszewski@...com.pl>
Diagnosed-by: Andrej Ota <andrej@....si>
Diagnosed-by: Eric Dumazet <eric.dumazet@...il.com>
Tested-by: Denys Fedoryshchenko <nuclearcat@...learcat.com>
Tested-by: Pawel Staszewski <pstaszewski@...com.pl>
Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
Signed-off-by: Andrej Ota <andrej@....si>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html