netdev - Re: [PATCH 2/9] drivers/net: don't use flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D068FD1.8080304@myri.com>
Date:	Mon, 13 Dec 2010 16:27:45 -0500
From:	Andrew Gallatin <gallatin@...i.com>
To:	Tejun Heo <tj@...nel.org>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, Jay Cliburn <jcliburn@...il.com>,
	Michael Chan <mchan@...adcom.com>,
	Divy Le Ray <divy@...lsio.com>,
	e1000-devel@...ts.sourceforge.net,
	Vasanthy Kolluri <vkolluri@...co.com>,
	Samuel Ortiz <samuel@...tiz.org>,
	Lennert Buytenhek <buytenh@...tstofly.org>,
	Francois Romieu <romieu@...zoreil.com>,
	Ramkrishna Vepa <ramkrishna.vepa@...r.com>,
	Matt Carlson <mcarlson@...adcom.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Shreyas Bhatewara <sbhatewara@...are.com>
Subject: Re: [PATCH 2/9] drivers/net: don't use flush_scheduled_work()

On 12/12/10 10:52, Tejun Heo wrote:
> flush_scheduled_work() is on its way out.  This patch contains simple
> conversions to replace flush_scheduled_work() usage with direct
> cancels and flushes.
>
> Directly cancel the used works on driver detach and flush them in
> other cases.
>
> The conversions are mostly straight forward and the only dangers are,
>
> * Forgetting to cancel/flush one or more used works.
>
> * Cancelling when a work should be flushed (ie. the work must be
>    executed once scheduled whether the driver is detaching or not).
>
> I've gone over the changes multiple times but it would be much
> appreciated if you can review with the above points in mind.
>
> Signed-off-by: Tejun Heo<tj@...nel.org>
> Cc: "David S. Miller"<davem@...emloft.net>
> Cc: Jay Cliburn<jcliburn@...il.com>
> Cc: Michael Chan<mchan@...adcom.com>
> Cc: Divy Le Ray<divy@...lsio.com>
> Cc: e1000-devel@...ts.sourceforge.net
> Cc: Vasanthy Kolluri<vkolluri@...co.com>
> Cc: Samuel Ortiz<samuel@...tiz.org>
> Cc: Lennert Buytenhek<buytenh@...tstofly.org>
> Cc: Andrew Gallatin<gallatin@...i.com>
> Cc: Francois Romieu<romieu@...zoreil.com>
> Cc: Ramkrishna Vepa<ramkrishna.vepa@...r.com>
> Cc: Matt Carlson<mcarlson@...adcom.com>
> Cc: David Brownell<dbrownell@...rs.sourceforge.net>
> Cc: Shreyas Bhatewara<sbhatewara@...are.com>
> Cc: netdev@...r.kernel.org
> ---


For the myri10ge part:

Acked-by: Andrew Gallatin <gallatin@...i.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html