lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Dec 2010 02:51:26 -0800 From: ebiederm@...ssion.com (Eric W. Biederman) To: Or Gerlitz <ogerlitz@...taire.com> Cc: Roland Dreier <rdreier@...co.com>, <netdev@...r.kernel.org> Subject: Re: correct include file for restart_syscall Or Gerlitz <ogerlitz@...taire.com> writes: > Hi, > > commit 26574401fef6766f6c3ca25b5c13febe662d2a32 "net: Fix ipoib rtnl_lock > sysfs deadlock" modified some flows doing rtnl_lock calls to use rtnl_trylock > / restart_syscall, etc. It turned out that restart_syscall was included in > ipoib through linux/inet_lro.h which is an include I'd like to remove... > Is including linux/sched.h being the right thing to do? I wasn't sure as > this call is very rare, in network drivers its called only by ipoib and > bonding and it looks like bonding includes it indirectly. For the definition of restart_syscall yes. I wish I was clever enough to find a way not to need rtnl_trylock restart_syscall but unfortunately I don't :( Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists