netdev - Re: [*v2 PATCH 01/22] IPVS: netns, add basic init per netns.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292253128.4983.53.camel@seasc0214>
Date:	Mon, 13 Dec 2010 16:12:08 +0100
From:	Hans Schillstrom <hans.schillstrom@...csson.com>
To:	Jan Engelhardt <jengelh@...ozas.de>
CC:	"horms@...ge.net.au" <horms@...ge.net.au>, "ja@....bg" <ja@....bg>,
	"daniel.lezcano@...e.fr" <daniel.lezcano@...e.fr>,
	"wensong@...ux-vs.org" <wensong@...ux-vs.org>,
	"lvs-devel@...r.kernel.org" <lvs-devel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"hans@...illstrom.com" <hans@...illstrom.com>
Subject: Re: [*v2 PATCH 01/22] IPVS: netns, add basic init per netns.

On Mon, 2010-12-13 at 15:08 +0100, Jan Engelhardt wrote:
> On Monday 2010-12-13 14:38, Hans Schillstrom wrote:
> >@@ -28,6 +28,18 @@
> > #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
> > #include <net/netfilter/nf_conntrack.h>
> > #endif
> >+#include <net/net_namespace.h>		/* Netw namespace */
> >+
> >+/*
> >+ * Generic access of ipvs struct
> >+ */
> >+static inline struct netns_ipvs * net_ipvs(struct net* net) {
> >+#ifdef CONFIG_NET_NS
> >+	return net->ipvs;
> >+#else
> >+	return init_net.ipvs;
> >+#endif
> >+}
> 
> This looks redundant, because even in the !CONFIG_NET_NS case,
> 'net' is valid and already points to &init_net.

Yes, that's right I'll remove it.

Thanks
Hans
> 
> >+static void __net_exit __ip_vs_cleanup(struct net *net)
> >+{
> >+	struct netns_ipvs *ipvs = net_ipvs(net);
> >+
> >+	IP_VS_DBG(10, "ipvs netns %d released\n", ipvs->inc);
> >+}
> >+


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html