netdev - Re: [RFC PATCH net-next] if_ether.h: Add #define ETH_P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101215212207.GA2548@broadcom.com>
Date:	Wed, 15 Dec 2010 13:22:07 -0800
From:	"Henry Ptasinski" <henryp@...adcom.com>
To:	"Joe Perches" <joe@...ches.com>
cc:	netdev <netdev@...r.kernel.org>,
	"Brett Rudley" <brudley@...adcom.com>,
	"Dowan Kim" <dowan@...adcom.com>,
	"Arend Van Spriel" <arend@...adcom.com>,
	"Roland Vossen" <rvossen@...adcom.com>
Subject: Re: [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for
 HPNA/LARQ

On Mon, Dec 13, 2010 at 07:53:51PM -0800, Joe Perches wrote:
> On Mon, 2010-12-13 at 17:49 -0800, Henry Ptasinski wrote:
> > On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote:
> > > LARQ seems to be used by Broadcom's staging driver.
> > > Might as well add a #define for it to the normal location.
> > > diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
> []
> > > +#define ETH_P_LARQ	0x886c		/* HPNA / Broadcom
> > That should be ETH_P_BRCM (or ETH_P_EPIGRAM).  HPNA/ILCP used a range of
> > subtypes for LARQ and other HPNA protocols.  The brcmfmac driver uses a
> > different subypte for encapsulating some event signals between the device and
> > the host, but doesn't implement any of the HPNA protocols.
> 
> Another choice might be ETH_P_LINK_CTL
> 

That would be fine too.

- Henry

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html