netdev - Re: [PATCHv2] fragment locally-generated IPsec6 packets that need it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101215005941.GA20448@gondor.apana.org.au>
Date:	Wed, 15 Dec 2010 08:59:41 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David L Stevens <dlstevens@...ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCHv2] fragment locally-generated IPsec6 packets that need
	it

On Tue, Dec 14, 2010 at 10:32:34AM -0800, David L Stevens wrote:
>
> @@ -88,8 +89,17 @@ static int xfrm6_output_finish(struct sk
>  	return xfrm_output(skb);
>  }
>  
> -int xfrm6_output(struct sk_buff *skb)
> +static int __xfrm6_output(struct sk_buff *skb)
>  {
>  	return NF_HOOK(NFPROTO_IPV6, NF_INET_POST_ROUTING, skb, NULL,
>  		       skb_dst(skb)->dev, xfrm6_output_finish);
>  }
> +
> +int xfrm6_output(struct sk_buff *skb)
> +{
> +	if ((skb->len > ip6_skb_dst_mtu(skb) && !skb_is_gso(skb)) ||
> +		dst_allfrag(skb_dst(skb))) {
> +			return ip6_fragment(skb, __xfrm6_output);
> +	}
> +	return __xfrm6_output(skb);
> +}

Oops, I didn't notice this the first time around.  The fragmentation
call should occur after POST_ROUTING.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html