netdev - Re: pktgen IP address stepping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101216211153.GA8658@spritelink.se>
Date:	Thu, 16 Dec 2010 22:11:54 +0100
From:	Kristian Larsson <kristian@...itelink.net>
To:	Joe Perches <joe@...ches.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: pktgen IP address stepping

On Thu, Dec 16, 2010 at 10:02:12AM -0800, Joe Perches wrote:
> pr_<foo> calls are already prefixed with pktgen via pr_fmt,
> you don't need to add it to the format string.

I can see at least two different cases of debug statements;

    if (debug)
        pr_info("Delay set at: %llu ns\n", pkt_dev->delay);

    if (debug)
        printk(KERN_DEBUG "pktgen: dst_min set to: %s\n",
               pkt_dev->dst_min);

what's the reasoning behind using one or the other?

   -K

-- 
Kristian Larsson                                        KLL-RIPE
+46 704 264511			              kll@...itelink.net
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html