netdev - Re: [PATCH net-next-2.6] net: force a fresh timestamp for ingress packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292538363.2655.20.camel@edumazet-laptop>
Date:	Thu, 16 Dec 2010 23:26:03 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Changli Gao <xiaosuo@...il.com>,
	netdev <netdev@...r.kernel.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net-next-2.6] net: force a fresh timestamp for ingress
 packets

Le jeudi 16 décembre 2010 à 23:08 +0100, Jarek Poplawski a écrit :

> Hmm... Do you expect more people start debugging SFQ or I missed your
> point? ;-) Maybe such a change would be reasonable on a cloned skb?

My point was to permit an admin to check his ingress shaping works or
not. In this respect, netem was a specialization of a general problem.

We had a prior discussion on timestamping skb in RX path, when RPS came
in : Should we take timestamp before RPS or after. At that time we added
a sysctl. Not sure it was the right choice :-(

I feel tcpdump (on TX side) should really display time of packet right
before being given to device, but this is probably a matter of taste.

Before commit 8caf153974f2 (net: sch_netem: Fix an inconsistency in
ingress netem timestamps.), this is what was done.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html