netdev - Re: [PATCH v2 1/2] bonding: generic netlink infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101216151207.3ead4c21@nehalam>
Date:	Thu, 16 Dec 2010 15:12:07 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	netdev@...r.kernel.org, Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH v2 1/2] bonding: generic netlink infrastructure

On Thu, 16 Dec 2010 14:53:22 -0800
Jay Vosburgh <fubar@...ibm.com> wrote:

> Generic netlink infrastructure for bonding.  Includes two
> netlink operations: notification for slave link state change, and a
> "get mode" netlink command.
> ---

1. The printk() for error needs to either be dropped or turned into
   a real loggable message (ie add more info and printk level).

2. Don't use C99 comments to comment out stuff

3. checkpatch has other whitespace complaints.

4. Missing Signed-off-by:





-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html