lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1292690832.6533.39.camel@localhost> Date: Sat, 18 Dec 2010 16:47:12 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Jean-Michel Hautbois <jhautbois@...il.com> Cc: davem@...emloft.net, richard.cochran@...cron.at, shemminger@...tta.com, tj@...nel.org, randy.dunlap@...cle.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] net: phy: balance disable/enable irq on change On Sat, 2010-12-18 at 16:55 +0100, Jean-Michel Hautbois wrote: > When phy interface changes its status, it calls phy_change() function. > This function calls the interrupt disabling functions for the driver registered, but if this driver doesn't implement it, there is no IRQ disabling. After doing the work, we call enable_irq and not the respective driver function. This fixes it, as it could lead to an unbalanced IRQ. > > Signed-off-by: Jean-Michel Hautbois <jhautbois@...il.com> > --- > drivers/net/phy/phy.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index 7670aac..b28f2ac 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -89,7 +89,8 @@ static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts) > phydev->interrupts = interrupts; > if (phydev->drv->config_intr) > err = phydev->drv->config_intr(phydev); > - > + else > + err = -ENOSYS; [...] ENOSYS means missing system call. Perhaps EOPNOTSUPP is the appropriate error code. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists