netdev - [PATCH 2/4] net: phy: printk issues fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1292756331-3735-2-git-send-email-jhautbois@gmail.com>
Date:	Sun, 19 Dec 2010 11:58:49 +0100
From:	Jean-Michel Hautbois <jhautbois@...il.com>
To:	davem@...emloft.net
Cc:	richard.cochran@...cron.at, shemminger@...tta.com, tj@...nel.org,
	randy.dunlap@...cle.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jean-Michel Hautbois <jhautbois@...il.com>
Subject: [PATCH 2/4] net: phy: printk issues fixed

When calling net link change, pr_info and printk where interleaved.
Changed the way to print messages.

Signed-off-by: Jean-Michel Hautbois <jhautbois@...il.com>
---
 drivers/net/phy/phy.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 5f23e8e..4ab48d7 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -44,14 +44,14 @@
  */
 void phy_print_status(struct phy_device *phydev)
 {
-	pr_info("PHY: %s - Link is %s", dev_name(&phydev->dev),
-			phydev->link ? "Up" : "Down");
 	if (phydev->link)
-		printk(" - %d/%s", phydev->speed,
-				DUPLEX_FULL == phydev->duplex ?
-				"Full" : "Half");
-
-	printk("\n");
+		pr_info("PHY: %s - Link is up - %d/%s\n",
+				dev_name(&phydev->dev),
+				phydev->speed,
+				phydev->duplex == DUPLEX_FULL ? "Full" : "Half");
+	else
+		pr_info("PHY: %s - Link is down\n",
+				dev_name(&phydev->dev));
 }
 EXPORT_SYMBOL(phy_print_status);
 
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html