lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101219005715.GC12005@rere.qmqm.pl> Date: Sun, 19 Dec 2010 01:57:15 +0100 From: Michał Mirosław <mirq-linux@...e.qmqm.pl> To: Ben Hutchings <bhutchings@...arflare.com> Cc: netdev@...r.kernel.org Subject: Re: [RFC PATCH 04/12] net: introduce NETIF_F_RXCSUM On Thu, Dec 16, 2010 at 11:27:29PM +0000, Ben Hutchings wrote: > On Wed, 2010-12-15 at 23:24 +0100, Michał Mirosław wrote: > > Introduce NETIF_F_RXCSUM to replace device-private flags for RX checksum > > offload. Integrate it with ndo_fix_features. > > > > ethtool_op_get_rx_csum() is removed altogether as nothing in-tree uses it. > Not explicitly, but what about drivers that turn TX and RX checksumming > on and off together? They are implicitly covered by the case which > you're removing: > [...] > > - case ETHTOOL_GRXCSUM: > > - rc = ethtool_get_value(dev, useraddr, ethcmd, > > - (dev->ethtool_ops->get_rx_csum ? > > - dev->ethtool_ops->get_rx_csum : > > - ethtool_op_get_rx_csum)); > [...] I had an impression that drivers not defining get_rx_csum() had no RX checksumming or didn't allow it to be toggled. I'll have a closer look on this. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists