netdev - Re: Kernel panic eth2 mirred redirect to ifb0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Dec 2010 20:30:39 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Paweł Staszewski <pstaszewski@...are.pl>
Cc:	Jarek Poplawski <jarkao2@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Network Development list <netdev@...r.kernel.org>
Subject: Re: Kernel panic eth2 mirred redirect to ifb0

2010/12/20 Paweł Staszewski <pstaszewski@...are.pl>:
> With this patch:
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index ca9036d..602cd32 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -6096,6 +6096,15 @@ static int ixgbe_tso(struct ixgbe_adapter *adapter,
>        u32 mss_l4len_idx, l4len;
>
>        if (skb_is_gso(skb)) {
> +               if (skb_shared(skb)) {
> +                       struct sk_buff *nskb;
> +
> +                       nskb = skb_clone(skb, GFP_ATOMIC);
> +                       if (!nskb)
> +                               return -ENOMEM;
> +                       kfree_skb(skb);
> +                       skb = nskb;
> +               }
>                if (skb_header_cloned(skb)) {
>                        err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC);
>                        if (err)
>
>
> I have the same panic as without.
>
> This patch was added to clean 2.6.37-rc6 - without previous patch for
> sch_generic.h
>
> Attached image with kernel panic.
>
>

Sigh. We have to revert my patch first. :(

-- 
Regards,
Changli Gao(xiaosuo@...il.com)