netdev - Re: [net-next-2.6 PATCH 4/4] net_sched: add MQSAFE flag to qdisc to identify mq like qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292887321.3055.43.camel@bwh-desktop>
Date:	Mon, 20 Dec 2010 23:22:01 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	John Fastabend <john.r.fastabend@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, hadi@...erus.ca,
	shemminger@...tta.com, tgraf@...radead.org, eric.dumazet@...il.com,
	nhorman@...driver.com
Subject: Re: [net-next-2.6 PATCH 4/4] net_sched: add MQSAFE flag to qdisc
 to identify mq like qdiscs

On Fri, 2010-12-17 at 07:34 -0800, John Fastabend wrote:
> Add a MQSAFE flag to the qdisc schedulers that can be safely
> managed by sch_mclass. Without this flag schedulers that are
> not aware of multiple tx queues can be grafted under the
> mclass qdisc. Allowing incorrect qdiscs to be grafted causes
> an invalid mapping from qdisc's to netdevice queues.
[...]

This should be defined before adding sch_mclass, or at the same time,
not after.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html