netdev - Re: [PATCH] tcp: cleanup of cwnd initialization in tcp_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101223.095615.39194231.davem@davemloft.net>
Date:	Thu, 23 Dec 2010 09:56:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jkosina@...e.cz
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, vojtech@...e.cz,
	ilpo.jarvinen@...sinki.fi
Subject: Re: [PATCH] tcp: cleanup of cwnd initialization in
 tcp_init_metrics()

From: Jiri Kosina <jkosina@...e.cz>
Date: Thu, 23 Dec 2010 10:23:38 +0100 (CET)

> Right, that's even better. Updated patch below.
> 
> 
> From: Jiri Kosina <jkosina@...e.cz>
> Subject: [PATCH] tcp: cleanup of cwnd initialization in tcp_init_metrics()
> 
> Commit 86bcebafc5e7f5 ("tcp: fix >2 iw selection") fixed a case
> when congestion window initialization has been mistakenly omitted
> by introducing cwnd label and putting backwards goto from the
> end of the function.
> 
> This makes the code unnecessarily tricky to read and understand
> on a first sight.
> 
> Shuffle the code around a little bit to make it more obvious.
> 
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html