lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20101223.102216.260073588.davem@davemloft.net> Date: Thu, 23 Dec 2010 10:22:16 -0800 (PST) From: David Miller <davem@...emloft.net> To: error27@...il.com Cc: gregkh@...e.de, linux-usb@...r.kernel.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] USB: mcs7830: return negative if auto negotiate fails From: Dan Carpenter <error27@...il.com> Date: Fri, 17 Dec 2010 16:25:43 +0300 > The original code returns 0 on success and 1 on failure. In fact, at > this point, "ret" is already either zero or a negative error code so > we can just return it directly. > > Signed-off-by: Dan Carpenter <error27@...il.com> Indeed, the USBNET ->bind() method, which this return value propagates to, expects negative return values on error. Applied, and queued up for -stable, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists