lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101224084538.GA2791@psychotron.redhat.com> Date: Fri, 24 Dec 2010 09:45:39 +0100 From: Jiri Pirko <jpirko@...hat.com> To: Dan Carpenter <error27@...il.com> Cc: netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>, H Hartley Sweeten <hsweeten@...ionengravers.com>, "David S. Miller" <davem@...emloft.net>, kernel-janitors@...r.kernel.org Subject: Re: [patch] skfp: testing the wrong variable in skfp_driver_init() Fri, Dec 24, 2010 at 06:17:34AM CET, error27@...il.com wrote: >The intent here was to test if the allocation failed but we tested >"SharedMemSize" instead of "SharedMemAddr" by mistake. > >Signed-off-by: Dan Carpenter <error27@...il.com> > >diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c >index 0a66fed..16c6265 100644 >--- a/drivers/net/skfp/skfddi.c >+++ b/drivers/net/skfp/skfddi.c >@@ -412,7 +412,7 @@ static int skfp_driver_init(struct net_device *dev) > bp->SharedMemAddr = pci_alloc_consistent(&bp->pdev, > bp->SharedMemSize, > &bp->SharedMemDMA); >- if (!bp->SharedMemSize) { >+ if (!bp->SharedMemAddr) { > printk("could not allocate mem for "); > printk("hardware module: %ld byte\n", > bp->SharedMemSize); Looks obvious. Reviewed-by: Jiri Pirko <jpirko@...hat.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists