lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101224005550.GA14050@strlen.de> Date: Fri, 24 Dec 2010 01:55:50 +0100 From: Florian Westphal <fw@...len.de> To: Changli Gao <xiaosuo@...il.com> Cc: eric.dumazet@...il.com, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org Subject: Re: [PATCH 1/1] netfilter: ebtables: make broute table work again Changli Gao <xiaosuo@...il.com> wrote: > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > > index 6f6d8e1..1d677bf 100644 > > --- a/net/bridge/br_input.c > > +++ b/net/bridge/br_input.c > > @@ -178,7 +178,7 @@ forward: > > case BR_STATE_FORWARDING: > > rhook = rcu_dereference(br_should_route_hook); > > if (rhook) { > > - if ((*rhook)(skb)) > > + if (rhook(skb)) > > I don't think this change is necessary. Would you like to remove this > change and test again? Its not needed, but i consider it less confusing. I do not have a strong preference, though. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists