lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1012252144030.10759@swampdragon.chaosbits.net> Date: Sat, 25 Dec 2010 21:45:26 +0100 (CET) From: Jesper Juhl <jj@...osbits.net> To: richard -rw- weinberger <richard.weinberger@...il.com> cc: netdev@...r.kernel.org, Steffen Klassert <klassert@...hematik.tu-chemnitz.de>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] 3c59x: Don't assign when a comparison is intended On Sat, 25 Dec 2010, richard -rw- weinberger wrote: > On Sat, Dec 25, 2010 at 9:30 PM, Jesper Juhl <jj@...osbits.net> wrote: > > Hi, > > > > In drivers/net/3c59x.c::vortex_probe1() we have this code: > > > > if (gendev) { > > if ((pdev = DEVICE_PCI(gendev))) { > > print_name = pci_name(pdev); > > } > > > > if ((edev = DEVICE_EISA(gendev))) { > > print_name = dev_name(&edev->dev); > > } > > } > > > > I believe these assignments were intended to be comparisons. > > If I'm correct, then here's a patch to fix that up. > > I don't think so. Look at the extra brackets. > > The code can also written as: > > pdev = DEVICE_PCI(gendev); > if(pdev) > print_name = pci_name(pdev); > Arrgh, I completely missed that - damn. You are correct I think and my patch is wrong. Thanks for taking a look. -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.
Powered by blists - more mailing lists