netdev - Re: [PATCH 7/9] can: janz-ican3: cleanup of ican3_to_can_frame and can_frame_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101225.193231.71107198.davem@davemloft.net>
Date:	Sat, 25 Dec 2010 19:32:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mkl@...gutronix.de
Cc:	netdev@...r.kernel.org, socketcan-core@...ts.berlios.de,
	iws@...o.caltech.edu
Subject: Re: [PATCH 7/9] can: janz-ican3: cleanup of ican3_to_can_frame and
 can_frame_to_ican3

From: Marc Kleine-Budde <mkl@...gutronix.de>
Date: Sat, 25 Dec 2010 15:40:32 +0100

> @@ -1421,6 +1421,9 @@ static int ican3_xmit(struct sk_buff *skb, struct net_device *ndev)
>  	void __iomem *desc_addr;
>  	unsigned long flags;
>  
> +	if (can_dropped_invalid_skb(dev, skb))
> +		return NETDEV_TX_OK;
> +

You never compile tested this.

Merry Christmas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html