netdev - Re: [PATCH] ipv4: dont create routes on down devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101225.200559.112599615.davem@davemloft.net>
Date:	Sat, 25 Dec 2010 20:05:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	opurdila@...acom.com
Cc:	eric.dumazet@...il.com, nicolas.dichtel@...nd.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: dont create routes on down devices

From: Octavian Purdila <opurdila@...acom.com>
Date: Thu, 23 Dec 2010 10:50:25 +0200

> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Wednesday 22 December 2010, 16:39:39
> 
>> [PATCH] ipv4: dont create routes on down devices
>> 
>> In ip_route_output_slow(), instead of allowing a route to be created on
>> a not UPed device, report -ENETUNREACH immediately.
>> 
>> # ip tunnel add mode ipip remote 10.16.0.164 local
>> 10.16.0.72 dev eth0
>> # (Note : tunl1 is down)
>> # ping -I tunl1 10.1.2.3
>> PING 10.1.2.3 (10.1.2.3) from 192.168.18.5 tunl1: 56(84) bytes of data.
>> (nothing)
>> # ./a.out tunl1
>> # ip tunnel del tunl1
>> Message from syslogd@...lby at Dec 22 10:12:08 ...
>>   kernel: unregister_netdevice: waiting for tunl1 to become free.
>> Usage count = 3
>> 
>> After patch:
>> # ping -I tunl1 10.1.2.3
>> connect: Network is unreachable
>> 
>> 
>> Reported-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>> Cc: Octavian Purdila <opurdila@...acom.com>
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Thanks Eric !
> 
> Reviewed-by: Octavian Purdila <opurdila@...acom.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html