netdev - Re: [RFC PATCH v2] Gemini: Gigabit ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1012271956260.8215@localhost>
Date:	Mon, 27 Dec 2010 20:21:44 +0100 (CET)
From:	Hans Ulli Kroll <ulli.kroll@...glemail.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
cc:	Hans Ulli Kroll <ulli.kroll@...glemail.com>,
	gemini-board-dev@...ts.berlios.de, netdev@...r.kernel.org,
	Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de>
Subject: Re: [RFC PATCH v2] Gemini: Gigabit ethernet driver



On Mon, 27 Dec 2010, Michał Mirosław wrote:

> Driver for SL351x (Gemini) SoC ethernet peripheral. Based in part
> on work by Paulius Zaleckas and GPLd code from Raidsonic and other
> NAS vendors.
> 
> Tested on Raidsonic IcyBox 4220-B (dual SATA NAS).
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> 
> ---
> 
> Hans, please drop previous mail from the gemini-board-dev queue -
> it had broken headers.

mail is already out.

> +		.dis_tx = 1,
> +		.dis_rx = 1,
> +		.max_len = 2,	/* magic; 512 << max_len? */
> +		.ipv4_rx_chksum = 1,
> +		.ipv6_rx_chksum = 1,

This is what I found in some netbsd code for maxlen

#define	CONFIG0_MAXLEN_MASK			__BITS(8,10)
#define	CONFIG0_MAXLEN_GET(x)			(((x) >> 8) & 
CONFIG0_MAXLEN_MASK)
#define	CONFIG0_MAXLEN(x)			(((x) & 
CONFIG0_MAXLEN_MASK) << 8)
#define	CONFIG0_MAXLEN_1536			0
#define	CONFIG0_MAXLEN_1518			1
#define	CONFIG0_MAXLEN_1522			2
#define	CONFIG0_MAXLEN_1548			3
#define	CONFIG0_MAXLEN_JUMBO			4

spec. for the SL3616 says jumbo is 9k frames, but i didn't proved this.

BTW:

Why u64_stats ?
I see only a few driver are using u64_stats.
vlan, br_device and some intel driver 
no gigabit driver for marvell devices uses u64_stats

Ulli