lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <FCA91A92EE52B041906A0358FC28FCC38EF8E701E1@FRE1EXCH02.hq.exar.com> Date: Tue, 28 Dec 2010 13:51:27 -0800 From: Ramkrishna Vepa <Ramkrishna.Vepa@...r.com> To: Dan Carpenter <error27@...il.com> CC: Sivakumar Subramani <Sivakumar.Subramani@...r.com>, Sreenivasa Honnur <Sreenivasa.Honnur@...r.com>, Jon Mason <Jon.Mason@...r.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: RE: [patch] vxge: remove duplicated part of check {nodisc} > This is just a cleanup to make the static checkers happy. We don't need > to check "own" twice. > > Signed-off-by: Dan Carpenter <error27@...il.com> > > diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge- > traffic.c > index 42cc298..4c10d6c 100644 > --- a/drivers/net/vxge/vxge-traffic.c > +++ b/drivers/net/vxge/vxge-traffic.c > @@ -1240,7 +1240,7 @@ enum vxge_hw_status vxge_hw_ring_rxd_next_completed( > *t_code = (u8)VXGE_HW_RING_RXD_T_CODE_GET(control_0); > > /* check whether it is not the end */ > - if (!own || ((*t_code == VXGE_HW_RING_T_CODE_FRM_DROP) && own)) { > + if (!own || *t_code == VXGE_HW_RING_T_CODE_FRM_DROP) { > > vxge_assert(((struct vxge_hw_ring_rxd_1 *)rxdp)->host_control > != > 0); Looks good, thanks. Acked-by: Ram Vepa <ram.vepa@...r.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists