netdev - Re: [PATCH net-2.6] starfire: Replace broken preprocessor test for dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101228143936X.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 28 Dec 2010 14:39:36 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	akinobu.mita@...il.com
Cc:	ben@...adent.org.uk, davem@...emloft.net, ionut@...ula.org,
	netdev@...r.kernel.org, fujita.tomonori@....ntt.co.jp,
	akpm@...ux-foundation.org, ralf@...ux-mips.org
Subject: Re: [PATCH net-2.6] starfire: Replace broken preprocessor test for
 dma_addr_t size

On Tue, 28 Dec 2010 14:27:44 +0900
Akinobu Mita <akinobu.mita@...il.com> wrote:

> 2010/12/28 Ben Hutchings <ben@...adent.org.uk>:
> > Commit 56543af "starfire: use BUILD_BUG_ON for netdrv_addr_t" revealed
> > that the preprocessor condition used to find the size of dma_addr_t
> > yielded the wrong result for some architectures and configurations.
> > This was kluged for 64-bit PowerPC in commit 3e502e6 by adding yet
> > another case to the condition.  However, some MIPS configurations are
> > still handled incorrectly.
> >
> > Replace the preprocessor test with expressions using ?: or
> > __builtin_choose_expr() as necessary.
> 
> I remember ARCH_DMA_ADDR_T_64BIT was introduced to handle this kind of
> test easily.
> 
> So please use CONFIG_ARCH_DMA_ADDR_T_64BIT for this test.
> You may also need to set ARCH_DMA_ADDR_T_64BIT for the MIPS
> architecture correctly.

I already sent CONFIG_ARCH_DMA_ADDR_T_64BIT patch for MIPS. It has
been in -mm:

http://userweb.kernel.org/~akpm/mmotm/broken-out/mips-enable-arch_dma_addr_t_64bit-with-highmem-64bit_phys_addr-64bit.patch
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html