netdev - Re: [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Dec 2010 12:10:19 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Shawn Guo <shawn.guo@...escale.com>
Cc:	Baruch Siach <baruch@...s.co.il>, davem@...emloft.net,
	gerg@...pgear.com, eric@...rea.com, bryan.wu@...onical.com,
	r64343@...escale.com, B32542@...escale.com, lw@...o-electronics.de,
	w.sang@...gutronix.de, s.hauer@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH 03/10] net/fec: add mac field into platform data and
	consolidate fec_get_mac

Hi Shawn,

On Wed, Dec 29, 2010 at 07:08:29PM +0800, Shawn Guo wrote:
> On Wed, Dec 29, 2010 at 11:37:58AM +0100, Uwe Kleine-König wrote:
> > On Wed, Dec 29, 2010 at 06:30:15PM +0800, Shawn Guo wrote:
> > > > On Tue, Dec 28, 2010 at 10:55:48PM +0800, Shawn Guo wrote:
> > > [...]
> > > > > +	/*
> > > > > +	 * try to get mac address in following order:
> > > > > +	 *
> > > > > +	 * 1) kernel command line fec_mac=xx:xx:xx...
> > > > > +	 */
> > > > > +	iap = fec_mac_default;
> > > > > +
> > > > > +	/*
> > > > > +	 * 2) from flash or fuse (via platform data)
> > > > > +	 */
> > > > 
> > > > Again, how do you handle the dual MAC case?
> > > > 
> > > For the platform data case, the following patch reads both mac
> > > addresses.
> > > 
> > > [PATCH 09/10] ARM: mx28: read fec mac address from ocotp
> > > 
> > > +static int __init mx28evk_fec_get_mac(void)
> > > +{
> > > +       int i, ret;
> > > +       u32 val;
> > > +
> > > +       /*
> > > +        * OCOTP only stores the last 4 octets for each mac address,
> > > +        * so hard-coding the first two octets as Freescale OUI (00:04:9f)
> > > +        * is needed.
> > > +        */
> > > +       for (i = 0; i < 2; i++) {
> > > +               ret = mxs_read_ocotp(0x20 + i * 0x10, 1, &val);
> > > +               if (ret)
> > > +                       goto error;
> > > +
> > > +               mx28_fec_pdata[i].mac[0] = 0x00;
> > > +               mx28_fec_pdata[i].mac[1] = 0x04;
> > > +               mx28_fec_pdata[i].mac[2] = (val >> 24) & 0xff;
> > > +               mx28_fec_pdata[i].mac[3] = (val >> 16) & 0xff;
> > > +               mx28_fec_pdata[i].mac[4] = (val >> 8) & 0xff;
> > > +               mx28_fec_pdata[i].mac[5] = (val >> 0) & 0xff;
> > uuh.  Is ((val >> 24) & 0xff) supposed to be 0x9f?  If not this might
> > have unwanted effects (practical, don't know about legal ones).
> Yes, it is 0x9f.
Then maybe hardcode that, or at least warn if it's not?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html