lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Dec 2010 11:09:20 -0800 From: John Fastabend <john.r.fastabend@...el.com> To: Shmulik Ravid <shmulikr@...adcom.com> CC: "davem@...emloft.net" <davem@...emloft.net>, Eilon Greenstein <eilong@...adcom.com>, "Liu, Lucy" <lucy.liu@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [net-next-2.6 PATCH v2 1/4] dcbnl: adding DCBX engine capability On 12/30/2010 10:54 AM, John Fastabend wrote: > On 12/30/2010 8:26 AM, Shmulik Ravid wrote: >> Adding an optional DCBX capability and a pair for get-set routines for >> setting the device DCBX mode. The DCBX capability is a bit field of >> supported attributes. The user is expected to set the DCBX mode with a >> subset of the advertised attributes. >> >> This patch is dependent on the following patches: >> [net-next-2.6 PATCH 1/3] dcbnl: add support for ieee8021Qaz attributes >> [net-next-2.6 PATCH 2/3] dcbnl: add appliction tlv handlers >> [net-next-2.6 PATCH 3/3] net_dcb: add application notifiers >> >> Signed-off-by: Shmulik Ravid <shmulikr@...adcom.com> >> --- > > Acked-by: John Fastabend <john.r.fastabend@...el.com> > > Thanks for doing this Shmulik. > Sorry missed this on my first pass. > > +/* DCBX configuration */ > +static int dcbnl_getdcbx(struct net_device *netdev, struct nlattr **tb, > + u32 pid, u32 seq, u16 flags) > +{ > + int ret = -EINVAL; > + > + if (!netdev->dcbnl_ops->getdcbx) > + return ret; I think we should actually return -EOPNOTSUPP here. > + > + ret = dcbnl_reply(netdev->dcbnl_ops->getdcbx(netdev), RTM_GETDCB, > + DCB_CMD_GDCBX, DCB_ATTR_DCBX, pid, seq, flags); > + > + return ret; > +} > + -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists