netdev - Re: [PATCH/RFC] Re: Compilation of pktgen fails for ARCH=um

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201012311126.30027.christoph.paasch@uclouvain.be>
Date:	Fri, 31 Dec 2010 11:26:29 +0100
From:	Christoph Paasch <christoph.paasch@...ouvain.be>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	netdev@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH/RFC] Re: Compilation of pktgen fails for ARCH=um

Hi,

On Thursday, December 30, 2010 wrote Randy Dunlap:
> or ndelay() in arch/um/include/asm/delay.y can be removed completely
> and then the default implementation of ndelay() will be used from
> include/linux/delay.h.
> This builds cleanly, but I don't know how well it would work.
This will do a rounded up micro-second sleep. I think that it's ok.

Christoph

> ---
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Allow uml to use the default implementation of ndelay() from
> <linux/delay.h>.  Fixes build error:
> 
> net/built-in.o: In function `spin':
> pktgen.c:(.text+0x27391): undefined reference to `__unimplemented_ndelay'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  arch/um/include/asm/delay.h |    5 -----
>  1 file changed, 5 deletions(-)
> 
> --- linux-next-20101214.orig/arch/um/include/asm/delay.h
> +++ linux-next-20101214/arch/um/include/asm/delay.h
> @@ -12,9 +12,4 @@ extern void __delay(unsigned long loops)
>  #define udelay(n) ((__builtin_constant_p(n) && (n) > 20000) ? \
>  	__bad_udelay() : __udelay(n))
> 
> -/* It appears that ndelay is not used at all for UML, and has never been
> - * implemented. */
> -extern void __unimplemented_ndelay(void);
> -#define ndelay(n) __unimplemented_ndelay()
> -
>  #endif

--
Christoph Paasch
PhD Student

IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://inl.info.ucl.ac.be/mptcp
Université Catholique de Louvain

www.rollerbulls.be
--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html