netdev - Re: [PATCH] UDPCP Communication Protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101231094634.5b96e0d1@s6510>
Date:	Fri, 31 Dec 2010 09:46:34 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	stefani@...bold.net
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] UDPCP Communication Protocol

On Fri, 31 Dec 2010 10:29:45 +0100
stefani@...bold.net wrote:

> +struct __attribute__ ((packed)) udpcphdr {
> +	struct udphdr udphdr;
> +	__be32 chksum;
> +	__be16 msginfo;
> +	u8 fragamount;
> +	u8 fragnum;
> +	__be16 msgid;
> +	__be16 length;
> +};

Adding (unnecessary) packed attribute will make access slow on
some architectures. For arch that can't do unaligned access, the
compiler ends up doing byte access for each element.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html