netdev - Re: [PATCH NEXT 2/3] netxen: enable LRO based on NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101231.105812.39181789.davem@davemloft.net>
Date:	Fri, 31 Dec 2010 10:58:12 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	amit.salecha@...gic.com
Cc:	netdev@...r.kernel.org, ameen.rahman@...gic.com,
	anirban.chakraborty@...gic.com, sucheta.chakraborty@...gic.com
Subject: Re: [PATCH NEXT 2/3] netxen: enable LRO based on NETIF_F_LRO

From: Amit Kumar Salecha <amit.salecha@...gic.com>
Date: Mon, 27 Dec 2010 00:43:42 -0800

> +	if (!!data) {

This form of the test is not only unnecessary, it's ugly.  Please just
test plain "data".

> +		dev->features &= ~NETIF_F_LRO;
> +		netxen_send_lro_cleanup(adapter);
> +		dev_info(&adapter->pdev->dev,
> +					"disabling LRO as rx_csum is off\n");

You should use netdev_info() and fix the tabbing here.

> +	if (!adapter->rx_csum) {
> +		dev_info(&adapter->pdev->dev, "rx csum is off, "
> +			"cannot toggle LRO\n");
> +		return -EINVAL;
> +	}

Please use netdev_info().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html