netdev - Re: [PATCH] new UDPCP Communication Protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1101022239010.11481@swampdragon.chaosbits.net>
Date:	Sun, 2 Jan 2011 22:40:38 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Stefani Seibold <stefani@...bold.net>
cc:	Daniel Baluta <daniel.baluta@...il.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	davem@...emloft.net, netdev@...r.kernel.org,
	eric.dumazet@...il.com, shemminger@...tta.com
Subject: Re: [PATCH] new UDPCP Communication Protocol

On Sun, 2 Jan 2011, Stefani Seibold wrote:

> Am Sonntag, den 02.01.2011, 21:48 +0200 schrieb Daniel Baluta:
> > Hello,
> > 
> > I have some style comments, please read below.
> > 
> > > +struct udpcp_statistics {
> > > +       unsigned int txMsgs;            /* Num of transmitted messages */
> > > +       unsigned int rxMsgs;            /* Num of received messages */
> > > +       unsigned int txNodes;           /* Num of receiver nodes */
> > > +       unsigned int rxNodes;           /* Num of transmitter nodes */
> > > +       unsigned int txTimeout;         /* Num of unsuccessful transmissions */
> > > +       unsigned int rxTimeout;         /* Num of partial message receptions */
> > > +       unsigned int txRetries;         /* Num of resends */
> > > +       unsigned int rxDiscardedFrags;  /* Num of discarded fragments */
> > > +       unsigned int crcErrors;         /* Num of crc errors detected */
> > 
> > Is there any strong reason to have this camel case naming?
[...]
> > 
> > same here.
> > 
> 
> I think there is no nameing convention in linux, as i know it is a
> developer decision.
> 

Chapter 4 of Documentation/CodingStyle seems to disagree with you:


"                Chapter 4: Naming

C is a Spartan language, and so should your naming be.  Unlike Modula-2
and Pascal programmers, C programmers do not use cute names like
ThisVariableIsATemporaryCounter.  A C programmer would call that
variable "tmp", which is much easier to write, and not the least more
difficult to understand.

HOWEVER, while mixed-case names are frowned upon, descriptive names for
global variables are a must.  To call a global function "foo" is a
shooting offense.
"

This seems (to me at least) to suggest that CammelCase is frawned upon.


-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html