netdev - RE: [net-next-2.6 08/08] r8169: more 8168dp support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C4B63551EF6C4B57BB20D6922F78AA12@realtek.com.tw>
Date:	Mon, 3 Jan 2011 20:50:03 +0800
From:	hayeswang <hayeswang@...ltek.com>
To:	'Francois Romieu' <romieu@...zoreil.com>, <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, 'Ben Hutchings' <benh@...ian.org>
Subject: RE: [net-next-2.6 08/08] r8169: more 8168dp support.

> From: Francois Romieu [mailto:romieu@...zoreil.com] 
> Sent: Monday, January 03, 2011 7:38 AM
> To: davem@...emloft.net
> Cc: netdev@...r.kernel.org; Hayeswang; Ben Hutchings
> Subject: [net-next-2.6 08/08] r8169: more 8168dp support.
> 
> Adapted from version 8.019.00 of Realtek's r8168 driver
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Hayes <hayeswang@...ltek.com>
> ---
> @@ -3038,8 +3104,10 @@ static void __devexit 
> rtl8169_remove_one(struct pci_dev *pdev)
>  	struct net_device *dev = pci_get_drvdata(pdev);
>  	struct rtl8169_private *tp = netdev_priv(dev);
>  
> -	if (tp->mac_version == RTL_GIGA_MAC_VER_27)
> +	if ((tp->mac_version == RTL_GIGA_MAC_VER_27) ||
> +	    (tp->mac_version == RTL_GIGA_MAC_VER_28)) {
>  		rtl8168_driver_stop(tp);
> +	}
>  
>  	cancel_delayed_work_sync(&tp->task);
>  
> @@ -3122,11 +3190,19 @@ err_pm_runtime_put:
>  	goto out;
>  }
>  
> -static void rtl8169_hw_reset(void __iomem *ioaddr)
> +static void rtl8169_hw_reset(struct rtl8169_private *tp)
>  {
> +	void __iomem *ioaddr = tp->mmio_addr;
> +
>  	/* Disable interrupts */
>  	rtl8169_irq_mask_and_ack(ioaddr);
>  
> +	if (tp->mac_version == RTL_GIGA_MAC_VER_28) {

This check should include RTL_GIGA_MAC_VER_27.

> +		while (RTL_R8(TxPoll) & NPQ)
> +			udelay(20);
> +
> +	}
> +
>  	/* Reset the chipset */
>  	RTL_W8(ChipCmd, CmdReset);
>  

After the reset, there are something to do for RTL_GIGA_MAC_VER_27. You may
check the soure code of realtek. Find "rtl8168_nic_reset".
 
Best Regards,
Hayes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html