netdev - Re: [PATCH V4] bridge: fix br_multicast_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110103.112926.48505128.davem@davemloft.net>
Date:	Mon, 03 Jan 2011 11:29:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	tomas.winkler@...el.com
Cc:	netdev@...r.kernel.org, johannes@...solutions.net,
	shemminger@...tta.com
Subject: Re: [PATCH V4] bridge: fix br_multicast_ipv6_rcv for paged skbs

From: Tomas Winkler <tomas.winkler@...el.com>
Date: Mon,  3 Jan 2011 12:37:59 +0200

> use pskb_may_pull to access ipv6 header correctly for paged skbs
> It was omitted in the bridge code leading to crash in blind
> __skb_pull
> 
> since the skb is cloned undonditionally we also simplify the
> the exit path
> 
> this fixes bug https://bugzilla.kernel.org/show_bug.cgi?id=25202
 ...
> Cc: David Miller <davem@...emloft.net>
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: Stephen Hemminger <shemminger@...tta.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>

Looks good, applied thanks Tomas.

There are several simplifications we can make in the net-next-2.6
tree.

Most of this code just wants the query type and then optionally
the ipv6 address the operation applies to.  For such simple value
fetching, skb_header_pointer() is probably ideal compared to
all of this pskb_may_pull() business.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html