netdev - Re: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110103.115319.245401044.davem@davemloft.net>
Date:	Mon, 03 Jan 2011 11:53:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sedat.dilek@...glemail.com
Cc:	samuel@...tiz.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, sedat.dilek@...il.com
Subject: Re: [PATCH] smsc-ircc2: Fix section mismatch derived from
 smsc_ircc_pnp_driver variable

From: Sedat Dilek <sedat.dilek@...glemail.com>
Date: Mon,  3 Jan 2011 03:28:44 +0100

>>>From my build.log:
> 
> drivers/net/irda/smsc-ircc2.o(.data+0x18): Section mismatch in reference from the variable smsc_ircc_pnp_driver to the function .init.text:smsc_ircc_pnp_probe()
> The variable smsc_ircc_pnp_driver references
> the function __init smsc_ircc_pnp_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
> 
> This patch fixes the warning.
> 
> Tested with linux-next (next-20101231)
> 
> Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>

Just like your other patch, this fix is not correct.

Mark smsc_ircc_pbp_probe() as __devinit instead of __init to fix
this bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html