lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Jan 2011 17:53:58 -0800 From: Stephen Hemminger <shemminger@...tta.com> To: Rick Jones <rick.jones2@...com> Cc: Ben Hutchings <bhutchings@...arflare.com>, Mahesh Bandewar <maheshb@...gle.com>, David Miller <davem@...emloft.net>, Laurent Chavey <chavey@...gle.com>, Tom Herbert <therbert@...gle.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH v2] net: Allow ethtool to set interface in loopback mode. On Tue, 04 Jan 2011 17:34:29 -0800 Rick Jones <rick.jones2@...com> wrote: > >>>Since this is a boolean it SHOULD go into ethtool_flags rather than > >>>being a high level operation. > >> > >>It could do, but I though ETHTOOL_{G,S}FLAGS were intended for > >>controlling offload features. > > > > > > It just seems the number of hooks keeps growing which takes more space > > and increases complexity. > > Is there any complication/downside to using flags in the (un?)likely event of > wanting different flavors of loopback in the card? > > rick jones Then let is keep it as command and have a parameter to set mode. There might be drivers that want to loopback in SW, HW, PHY or even switch. -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists