lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 05 Jan 2011 18:43:22 +0100 From: Krzysztof Halasa <khc@...waw.pl> To: Axel Lin <axel.lin@...il.com> Cc: linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] net: ixp4xx_eth: Return proper error for eth_init_one Axel Lin <axel.lin@...il.com> writes: > Return PTR_ERR(port->phydev) instead of 1 if phy_connect failed. > > Signed-off-by: Axel Lin <axel.lin@...il.com> > --- a/drivers/net/arm/ixp4xx_eth.c > +++ b/drivers/net/arm/ixp4xx_eth.c > @@ -1229,8 +1229,10 @@ static int __devinit eth_init_one(struct platform_device *pdev) > snprintf(phy_id, MII_BUS_ID_SIZE + 3, PHY_ID_FMT, "0", plat->phy); > port->phydev = phy_connect(dev, phy_id, &ixp4xx_adjust_link, 0, > PHY_INTERFACE_MODE_MII); > - if ((err = IS_ERR(port->phydev))) > + if (IS_ERR(port->phydev)) { > + err = PTR_ERR(port->phydev); > goto err_free_mem; > + } > > port->phydev->irq = PHY_POLL; Right. Thanks. Acked-by: Krzysztof Halasa <khc@...waw.pl> -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists