netdev - Re: [PATCH 2/3] tlan: Fix partner capability printout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1294341774.11825.27.camel@bwh-desktop>
Date:	Thu, 06 Jan 2011 19:22:54 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Sakari Ailus <sakari.ailus@....fi>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] tlan: Fix partner capability printout

On Thu, 2011-01-06 at 20:50 +0200, Sakari Ailus wrote:
> Fix partner capability printout. Add spaces and do not print null.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@....fi>
> ---
>  drivers/net/tlan.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/tlan.c b/drivers/net/tlan.c
> index 57380b1..090ce21 100644
> --- a/drivers/net/tlan.c
> +++ b/drivers/net/tlan.c
> @@ -2367,10 +2367,10 @@ tlan_finish_reset(struct net_device *dev)
>  					? "" : "0",
>  					tlphy_par & TLAN_PHY_DUPLEX_FULL
>  					? "Full" : "half");
> -				pr_info("TLAN: Partner capability: ");
> -				for (i = 5; i <= 10; i++)
> +				pr_info("TLAN: Partner capability:");
> +				for (i = 5; i < 10; i++)
>  					if (partner & (1<<i))
> -						printk("%s", media[i-5]);
> +						printk(" %s", media[i-5]);
>  				printk("\n");
>  			}
>  

Really you should remove this logging and report the information through
the ethtool interface.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html