lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 6 Jan 2011 11:07:56 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Paul Mackerras <paulus@...ba.org>, linux-ppp@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: ppp: use {get,put}_unaligned_be{16,32}

On Thu, Jan 6, 2011 at 1:37 AM, Changli Gao <xiaosuo@...il.com> wrote:
> Signed-off-by: Changli Gao <xiaosuo@...il.com>
> ---
>  drivers/net/ppp_async.c   |   10 +++++-----
>  drivers/net/ppp_deflate.c |    9 ++++-----
>  drivers/net/ppp_generic.c |    9 ++++-----
>  drivers/net/ppp_mppe.c    |    7 +++----
>  drivers/net/ppp_synctty.c |    3 ++-
>  5 files changed, 18 insertions(+), 20 deletions(-)
> diff --git a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c
> index 78d70a6..cbe1e13 100644
> --- a/drivers/net/ppp_async.c
> +++ b/drivers/net/ppp_async.c
> @@ -32,6 +32,7 @@
>  #include <linux/init.h>
>  #include <linux/jiffies.h>
>  #include <linux/slab.h>
> +#include <linux/unaligned/be_struct.h>

#include <asm/unaligned.h>

Same for the other occurances, otherwise looks OK.

Harvey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ