netdev - Re: [PATCH] ehea: Add some info messages and fix an issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110107142430.42fda498@kryten>
Date:	Fri, 7 Jan 2011 14:24:30 +1100
From:	Anton Blanchard <anton@...ba.org>
To:	leitao@...ux.vnet.ibm.com
Cc:	joe@...ches.com, netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] ehea: Add some info messages and fix an issue

Hi,

> From: Breno Leitao <breno@...e.(none)>
> 
> This patch adds some debug information about ehea not being able to
> allocate enough spaces. Also it correctly updates the amount of
> available skb.

I'm seeing issues on a number of machines with the ehea device.
Sometime after boot I see a bunch of:

ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL
ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL
ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL
ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL

which eventually stop.

-       for (i = 0; i < pr->rq1_skba.len; i++) {
+       for (i = 0; i < nr_rq1a; i++) {

It looks like you are now only initialising half the ring, but still
telling the hardware to use the whole ring. Once you get through the
entire ring once the errors go away.

Anton
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html